[ https://issues.apache.org/jira/browse/METRON-726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991160#comment-15991160 ]
ASF GitHub Bot commented on METRON-726: --------------------------------------- Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/459 Great, thanks @justinleet ! +1 on that part of it. I don't feel familiar enough with the other build stuff you modified to evaluate it, so hopefully you can get another +1 too. > Clean up mvn site generation > ---------------------------- > > Key: METRON-726 > URL: https://issues.apache.org/jira/browse/METRON-726 > Project: Metron > Issue Type: Bug > Reporter: Justin Leet > Assignee: Justin Leet > Priority: Minor > > Right now there's a couple issues with running mvn:site. The most obvious is > that EMMA appears to not work at all, but in attempting to fix that, several > other issues came to light. > Error seen: > {code} > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-site-plugin:3.3:site (default-site) on project > metron-maas-common: failed to get report for > org.codehaus.mojo:emma-maven-plugin: Failed to execute goal > org.codehaus.mojo:emma-maven-plugin:1.0-alpha-3:instrument (report:emma) on > project metron-maas-common: Execution report:emma of goal > org.codehaus.mojo:emma-maven-plugin:1.0-alpha-3:instrument failed: > CONSTANT_info: invalid tag value [18] -> [Help 1] > {code} > After commenting out everything EMMA, there are still some issues seen: > {code} > [WARNING] Unable to process class > org/apache/metron/test/converters/BinaryConverters.class in JarAnalyzer File > /Users/jleet/.m2/repository/org/apache/metron/metron-test-utilities/0.3.1/metron-test-utilities-0.3.1.jar > org.apache.bcel.classfile.ClassFormatException: Invalid byte tag in constant > pool: 18 > {code} > This seems to be a Java 8 issue, which means that EMMA likely is impossible > to make work. I'm unsure that's the root cause, but given the age of EMMA > plus (the outdated version of) BCEL thowing a very similar issue implies that > the Java version is related. This also implies that our {{mvn site}} hasn't > worked in a long time. > Cleaning this up should include at least > * Getting code coverage working again > * Consolidating reporting in our poms. A lot of it is repeated everywhere we > have Java. > * Ensure we can actually generate and look through the site. > * METRON-725 fixes Javadoc, so reporting will still have issues until that is > taken care of. > * Apparently checkstyle got dropped at some point. It's easy enough to add > in, and can be taken care of here. -- This message was sent by Atlassian JIRA (v6.3.15#6346)