[ 
https://issues.apache.org/jira/browse/METRON-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16009083#comment-16009083
 ] 

ASF GitHub Bot commented on METRON-746:
---------------------------------------

Github user justinleet commented on the issue:

    https://github.com/apache/metron/pull/577
  
    This appears to also work in Eclipse (similar deal: Install Checkstyle from 
Eclipse Marketplace, import GoogleStyle with the same instruction link as 
IntelliJ).
    
    Having said that, Eclipse really dislikes some plugins in our POMs, and it 
seems like an Eclipse thing.  I haven't dug in further, and to be blunt, am not 
interested in doing so unless someone really, really wants to work with Eclipse.


> Build Custom Checkstyle and IDE formatting settings
> ---------------------------------------------------
>
>                 Key: METRON-746
>                 URL: https://issues.apache.org/jira/browse/METRON-746
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Justin Leet
>            Assignee: Justin Leet
>            Priority: Minor
>
> We need a custom checkstyle.xml based off the sun convention checkstyle.  
> Based on a discussion thread, there are a few things that need to be setup
> * Two space indents
> * Line Length longer than 80 (pretty popular in the discussion, but not 
> officially part of our code style)
> * Appropriate warn/error levels set so we don't immediately start failing 
> every build.
> * Importable IntelliJ code style at minimum, but I'd also like to see Eclipse 
> if possible to avoid forcing a given dev environment.  IntelliJ allows for 
> importing a checkstyle.xml to use as the basis.  We can export the resulting 
> formatting settings for people.
> * Ensure Travis actually runs checkstyle during our builds



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to