[
https://issues.apache.org/jira/browse/METRON-936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012369#comment-16012369
]
ASF GitHub Bot commented on METRON-936:
---------------------------------------
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/585#discussion_r116742092
--- Diff:
metron-platform/metron-pcap-backend/src/main/java/org/apache/metron/spout/pcap/deserializer/KeyValueDeserializer.java
---
@@ -28,6 +26,17 @@
public abstract class KeyValueDeserializer implements Serializable {
protected TimestampConverter converter;
+ public static class Result {
--- End diff --
Can we call this something more informative than Result?
> Fixes to pcap for performance and testing
> -----------------------------------------
>
> Key: METRON-936
> URL: https://issues.apache.org/jira/browse/METRON-936
> Project: Metron
> Issue Type: Bug
> Reporter: Michael Miklavcic
> Assignee: Michael Miklavcic
>
> Default in pcap.properties for kafka.pcap.start=END, and it's also not used
> in the Flux file. topology.workers should also be provided via the properties
> file.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
