[
https://issues.apache.org/jira/browse/METRON-939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054058#comment-16054058
]
ASF GitHub Bot commented on METRON-939:
---------------------------------------
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/619#discussion_r122716256
--- Diff:
metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/integration/components/ElasticSearchComponent.java
---
@@ -178,8 +195,11 @@ public boolean hasIndex(String indexName) {
@Override
public void stop() {
- node.close();
+ try {
+ node.close();
+ } catch (IOException e) {
+ e.printStackTrace();
--- End diff --
We either want to throw up the exception or at least log it with a logger,
rather than stdout.
> Upgrade ElasticSearch and Kibana
> --------------------------------
>
> Key: METRON-939
> URL: https://issues.apache.org/jira/browse/METRON-939
> Project: Metron
> Issue Type: Improvement
> Reporter: Jon Zeolla
>
> Upgrade ElasticSearch and Kibana (latest is 5.4 as of writing this). Among
> other benefits, this allows us to use periods in field names
> (https://github.com/elastic/elasticsearch/pull/19937/files), which has been
> available as of 5.0 and 2.4, and the ability to index an IPv6 address
> properly
> (https://www.elastic.co/blog/indexing-ipv6-addresses-in-elasticsearch).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
