[
https://issues.apache.org/jira/browse/METRON-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16075280#comment-16075280
]
ASF GitHub Bot commented on METRON-1008:
----------------------------------------
GitHub user jjmeyer0 opened a pull request:
https://github.com/apache/metron/pull/632
METRON-1008: Updating travis to use trusty
….npm to cache.
Added some more cacheing from 1004 ticket.
Revert some changes.
Reverted environment and put maven opts in the correct spot.
Testing sudo as false.
Trying multiple vm build.
Revert back to two threads on maven install.
## Contributor Comments
I made travis use trusty. On top of this the following were added before
1004 was made, but I thought some things were worth keeping:
* Call to verify license is made right away to get quicker failures.
* Cache $HOME/.npm; After bringing in METRON-1004 it looks like this may
not be needed anymore?
* Set MAVEN_OPTS to set `-Xmx2g` out of curiosity
* Out of curiosity, multiple environments were added to see if build times
would dramatically increase. I know this may be undesirable, but I thought I'd
leave it in to discuss some. I'm leaning towards reverting this back as it only
seems to get it down to ~23 minutes. Any thoughts?
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [ ] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified
and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been
executed in the root incubating-metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [ ] Have you written or updated unit tests and or integration tests to
verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jjmeyer0/incubator-metron METRON-1008
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/632.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #632
----
commit cc9f234fd51493684767c854fc52d0fba7856496
Author: JJ <jjmey...@gmail.com>
Date: 2017-06-29T22:43:58Z
METRON-1008: Updating travis to use trusty, increase heap, and added .npm
to cache.
Added some more cacheing from 1004 ticket.
Revert some changes.
Reverted environment and put maven opts in the correct spot.
Testing sudo as false.
Trying multiple vm build.
Revert back to two threads on maven install.
commit a2a07df29f048cbf35c5f85d83073c2d776d93d8
Author: JJ <jjmey...@gmail.com>
Date: 2017-07-05T18:51:17Z
Properly setting MAVEN_OPTS.
----
> Migrate Travis build to use Trusty
> ----------------------------------
>
> Key: METRON-1008
> URL: https://issues.apache.org/jira/browse/METRON-1008
> Project: Metron
> Issue Type: Bug
> Reporter: Justin Leet
>
> [~zeo...@gmail.com] pinged someone from Travis while we were working on
> METRON-1004. In addition to confirming that we should be using a VM, it was
> also suggested we move to Trusty. This was briefly looked at in during
> METRON-1004, in particular because it (theoretically) has the correct version
> of compilers installed, so we could avoid the hit of setting that up. It
> blew up on `npm install`, possibly from my own ignorance.
> At minimum we should move to Trusty:
> {code}
> https://docs.travis-ci.com/user/trusty-ci-environment/
> {code}
> Ideally, we do some more thorough investigation of the compiler and see if we
> can cut out that step.
> See:
> https://docs.travis-ci.com/user/trusty-ci-environment/
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
