[
https://issues.apache.org/jira/browse/METRON-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16075499#comment-16075499
]
ASF GitHub Bot commented on METRON-1008:
----------------------------------------
Github user jjmeyer0 commented on the issue:
https://github.com/apache/metron/pull/633
Quote from @justinleet
> I'd be inclined towards avoiding splitting the build if we were only
getting a couple minutes out of it. I'm a little worried about being able to
get three slots on the occasionally stretched Apache setup. Integration tests
and building are the long poles in the tent, so splitting out the other tests
doesn't really save us much time here, unfortunately.
I agree, I have reverted this.
Quote from @ottobackwards
> I'm going to be honest. Now that we have the builds kind of working
again, I'm a little hesitant to change them for anything but an absolute
certainty of a return, that we completely understand.
>
> I think the travis build strategy should be a longer living branch maybe.
I reverted the multiple env changes, as I agree, it's not worth the small
chunk of time that was shaved off. However, I think the rest of these changes
can be helpful for the following reasons:
* moving the license verification to an earlier step can help the build
fail fast. Forgetting to update the dependency file can be a common mistake.
Failing earlier might save time and travis resources.
* I believe moving to trusty was recommended by travis-ci
* using travis' install step for the `mvn install`. No benefit that I know
of. I just believe `mvn install` should happen here.
> Migrate Travis build to use Trusty
> ----------------------------------
>
> Key: METRON-1008
> URL: https://issues.apache.org/jira/browse/METRON-1008
> Project: Metron
> Issue Type: Bug
> Reporter: Justin Leet
>
> [~zeo...@gmail.com] pinged someone from Travis while we were working on
> METRON-1004. In addition to confirming that we should be using a VM, it was
> also suggested we move to Trusty. This was briefly looked at in during
> METRON-1004, in particular because it (theoretically) has the correct version
> of compilers installed, so we could avoid the hit of setting that up. It
> blew up on `npm install`, possibly from my own ignorance.
> At minimum we should move to Trusty:
> {code}
> https://docs.travis-ci.com/user/trusty-ci-environment/
> {code}
> Ideally, we do some more thorough investigation of the compiler and see if we
> can cut out that step.
> See:
> https://docs.travis-ci.com/user/trusty-ci-environment/
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
