[ 
https://issues.apache.org/jira/browse/METRON-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16078303#comment-16078303
 ] 

Otto Fowler commented on METRON-1013:
-------------------------------------

How about attempt to connect to ZK on demand?


> StellarShell does not validate parameters like zookeeper urls properly
> ----------------------------------------------------------------------
>
>                 Key: METRON-1013
>                 URL: https://issues.apache.org/jira/browse/METRON-1013
>             Project: Metron
>          Issue Type: Bug
>    Affects Versions: 0.4.0
>            Reporter: Otto Fowler
>
> If you pass an invalid url to -z for example - you will get a wait and then 
> an exception crashing the shell.
> In the case of -z, I am not sure url is the right name, since we want 
> host:port, with host being a valid name or ip address and port.
> We also do use a default port if none is provided, we probably should.
> A 'dev' default for the whole thing would be 'node1:2181', to match our 
> vagrant environments.  I propose that we use that.
> Thus:
> * no -z => node1:2181
> * -z -> validate host name, if no port then 2181
> * if port then validate port



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to