[
https://issues.apache.org/jira/browse/METRON-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16082191#comment-16082191
]
ASF GitHub Bot commented on METRON-1017:
----------------------------------------
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/634#discussion_r126684827
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/indexing_commands.py
---
@@ -94,24 +96,24 @@ def init_hdfs_dir(self):
Logger.info('Done creating HDFS indexing directory')
def start_indexing_topology(self):
- Logger.info("Starting Metron indexing topology:
{0}".format(self.__indexing))
+ Logger.info("Starting Metron indexing topology:
{0}".format(self.__indexing_topology))
start_cmd_template = """{0}/bin/start_elasticsearch_topology.sh \
-s {1} \
-z {2}"""
- Logger.info('Starting ' + self.__indexing)
+ Logger.info('Starting ' + self.__indexing_topology)
if self.__params.security_enabled:
metron_security.kinit(self.__params.kinit_path_local,
self.__params.metron_keytab_path,
self.__params.metron_principal_name,
execute_user=self.__params.metron_user)
- Execute(start_cmd_template.format(self.__params.metron_home,
self.__indexing, self.__params.zookeeper_quorum),
+ Execute(start_cmd_template.format(self.__params.metron_home,
self.__indexing_topology, self.__params.zookeeper_quorum),
user=self.__params.metron_user)
Logger.info('Finished starting indexing topology')
def stop_indexing_topology(self):
- Logger.info('Stopping ' + self.__indexing)
- stop_cmd = 'storm kill ' + self.__indexing
+ Logger.info('Stopping ' + self.__indexing_topology)
--- End diff --
It looks like previously we were using the same variable to store the name
of the Indexing topology and topic name. Good catch.
> Ambari components should be separate
> ------------------------------------
>
> Key: METRON-1017
> URL: https://issues.apache.org/jira/browse/METRON-1017
> Project: Metron
> Issue Type: Bug
> Reporter: Ryan Merriman
> Assignee: Ryan Merriman
>
> This is a follow-up to METRON-990. During the review of that Jira it was
> pointed out that a config change should only prompt a restart of the affected
> component(s), not all components every time like it does now.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
