[ 
https://issues.apache.org/jira/browse/METRON-539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16083019#comment-16083019
 ] 

ASF GitHub Bot commented on METRON-539:
---------------------------------------

Github user ottobackwards commented on a diff in the pull request:

    https://github.com/apache/metron/pull/641#discussion_r126812613
  
    --- Diff: 
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/HashFunctions.java
 ---
    @@ -0,0 +1,85 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.metron.stellar.dsl.functions;
    +
    +import com.google.common.io.BaseEncoding;
    +import org.apache.commons.lang3.SerializationUtils;
    +import org.apache.metron.stellar.dsl.BaseStellarFunction;
    +import org.apache.metron.stellar.dsl.Stellar;
    +
    +import java.io.Serializable;
    +import java.nio.charset.StandardCharsets;
    +import java.security.MessageDigest;
    +import java.security.NoSuchAlgorithmException;
    +import java.util.List;
    +
    +public class HashFunctions {
    +  @Stellar(
    +    name = "HASH",
    +    description = "Hashes a given value using the given hashing algorithm 
and returns a hex encoded string. This function only hashes " +
    +      "strings and values that implement java.io.Serializable.",
    +    params = {
    +      "toHash - value to hash.",
    +      "hashType - A valid string representation of an algorithm supported 
by java.security.MessageDigest.",
    +    },
    +    returns = "A hex representation of a hashed value using the given 
hashing algorithm. If either argument is " +
    +      "null then null will be returned. If the type of 'toHash' is neither 
a string nor of type java.io.Serializable, " +
    +      "then null is returned."
    +  )
    +  public static class Hash extends BaseStellarFunction {
    +
    +    @Override
    +    public Object apply(final List<Object> args) {
    +      if (args == null || args.size() != 2) {
    +        throw new IllegalArgumentException("Invalid number of arguments: " 
+ (args == null ? 0 : args.size()));
    +      }
    +
    +      final Object toHash = args.get(0);
    +      final Object hashType = args.get(1);
    +
    +      if (toHash == null || hashType == null) {
    +        return null;
    +      }
    +
    +      final MessageDigest messageDigest = 
getMessageDigest(hashType.toString());
    +
    +      if (toHash instanceof String) {
    +        return getHashAsHex(messageDigest, 
toHash.toString().getBytes(StandardCharsets.UTF_8));
    +      } else if (toHash instanceof Serializable) {
    +        final byte[] serialized = 
SerializationUtils.serialize((Serializable) toHash);
    +        return getHashAsHex(messageDigest, serialized);
    +      }
    +
    +      return null;
    +    }
    +
    +    private MessageDigest getMessageDigest(String hashType) {
    --- End diff --
    
    Then again, I don't usually think of using the Stellar static classes on 
their own, or from 'other' stellar functions, maybe I'm not thinking of that 
correctly


> Add stellar keywords for hashing
> --------------------------------
>
>                 Key: METRON-539
>                 URL: https://issues.apache.org/jira/browse/METRON-539
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Jon Zeolla
>            Priority: Minor
>
> Stellar should have the ability to natively hash values using a prefix of TO 
> or HASH, then the algorithm, and an optional length.  For instance, 
> "TO_SHA3_256" or "HASH_MD5."



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to