[
https://issues.apache.org/jira/browse/METRON-539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16083310#comment-16083310
]
ASF GitHub Bot commented on METRON-539:
---------------------------------------
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/641#discussion_r126849654
--- Diff:
metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/HashFunctionsTest.java
---
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.metron.stellar.dsl.functions;
+
+import com.google.common.io.BaseEncoding;
+import org.apache.commons.lang.SerializationUtils;
+import org.junit.Test;
+
+import java.io.Serializable;
+import java.nio.charset.StandardCharsets;
+import java.security.MessageDigest;
+import java.security.NoSuchAlgorithmException;
+import java.security.Security;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Set;
+
+import static
org.apache.metron.stellar.common.utils.StellarProcessorUtils.run;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNull;
+
+public class HashFunctionsTest {
+ final HashFunctions.Hash hash = new HashFunctions.Hash();
+
+ @Test(expected = IllegalArgumentException.class)
+ public void nullArgumentListShouldThrowException() throws Exception {
+ hash.apply(null);
+ }
+
+ @Test(expected = IllegalArgumentException.class)
+ public void emptyArgumentListShouldThrowException() throws Exception {
+ hash.apply(Collections.emptyList());
+ }
+
+ @Test(expected = IllegalArgumentException.class)
+ public void singleArgumentListShouldThrowException() throws Exception {
+ hash.apply(Collections.singletonList("some value."));
+ }
+
+ @Test(expected = IllegalArgumentException.class)
+ public void argumentListWithMoreThanTwoValuesShouldThrowException3()
throws Exception {
+ hash.apply(Arrays.asList("1", "2", "3"));
+ }
+
+ @Test(expected = IllegalArgumentException.class)
+ public void argumentListWithMoreThanTwoValuesShouldThrowException4()
throws Exception {
+ hash.apply(Arrays.asList("1", "2", "3", "4"));
+ }
+
+ @Test(expected = IllegalArgumentException.class)
+ public void invalidAlgorithmArgumentShouldThrowException() throws
Exception {
+ hash.apply(Arrays.asList("value to hash", "invalidAlgorithm"));
+ }
+
+ @Test
+ public void invalidNullAlgorithmArgumentShouldThrowException() throws
Exception {
+ assertNull(hash.apply(Arrays.asList("value to hash", null)));
+ }
+
+ @Test
+ public void nullInputForValueToHashShouldProperlyThrowException() throws
Exception {
+ assertNull(hash.apply(Arrays.asList(null, "md5")));
+ }
--- End diff --
Ah, I was trusting your very detailed testcase names :-) If they don't
throw exceptions then of course the annotation should be consistent.
I remain of the opinion that it would be good for HASH to be able to return
a conforming result for null objects, ie "00" instead of null. But this is
mostly an aesthetic judgment on my part, so I could be talked out of it.
You gave me a headache by prefixing the "00" string with the unicode symbol
:-) and no, "\u0000" would not be the desirable return value; that would be the
unicode codepoint for a single null character. Yuck! But I shouldn't have
used the hex prefix "0x" either. Since we are returning unadorned string
values representing hex values, it should be "00" (a pair of zero digit
characters in a String of length 2).
> Add stellar keywords for hashing
> --------------------------------
>
> Key: METRON-539
> URL: https://issues.apache.org/jira/browse/METRON-539
> Project: Metron
> Issue Type: Improvement
> Reporter: Jon Zeolla
> Priority: Minor
>
> Stellar should have the ability to natively hash values using a prefix of TO
> or HASH, then the algorithm, and an optional length. For instance,
> "TO_SHA3_256" or "HASH_MD5."
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
