[ 
https://issues.apache.org/jira/browse/METRON-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16105391#comment-16105391
 ] 

ASF GitHub Bot commented on METRON-1060:
----------------------------------------

Github user mmiklavc commented on the issue:

    https://github.com/apache/metron/pull/665
  
    Hi @ottobackwards I actually took this advice and have a commit coming your 
way. I extracted functionality into a PerformanceLogger class that allows you 
to specify a percentage probability for logging the timing in the global 
config. A value of 1 logs roughly 1% of statements, 100 will log all 
statements. I could use some feedback on the approach I took for instantiating 
the logger - I used a local member variable instead of a static variable. The 
reason being that the logger maintains a Map<String, Long> of marked times. 
Since multiple executors may exist within a single worker JVM, it seemed likely 
that they might trample one another.


> Add performance timing logging to enrichment topology
> -----------------------------------------------------
>
>                 Key: METRON-1060
>                 URL: https://issues.apache.org/jira/browse/METRON-1060
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Michael Miklavcic
>            Assignee: Michael Miklavcic
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to