[
https://issues.apache.org/jira/browse/METRON-1068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136833#comment-16136833
]
ASF GitHub Bot commented on METRON-1068:
----------------------------------------
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/699#discussion_r134489911
--- Diff: metron-interface/metron-alerts/e2e/login/login.e2e-spec.ts ---
@@ -0,0 +1,44 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import { LoginPage } from './login.po';
+
+describe('login to application', function() {
+ let page: LoginPage;
+
+ beforeEach(() => {
+ page = new LoginPage();
+ });
+
+ it('should display error message for invalid credentials', () => {
--- End diff --
Personally, I think mocking the REST API makes sense here. Others may have
their own opinions. I don't think that should hold up all your work here
though. We can leave it as-is and revisit if necessary.
Can you document starting Full Dev as an additional step for running the
E2E tests in the README? That would make me happy.
Thanks
> Use Elastic end point in alerts ui
> ----------------------------------
>
> Key: METRON-1068
> URL: https://issues.apache.org/jira/browse/METRON-1068
> Project: Metron
> Issue Type: New Feature
> Reporter: RaghuMitra
> Assignee: RaghuMitra
>
> An elastic end point to retrieve data is added in metron. Alerts UI can make
> use of this rest-api instead of directly querying ES
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
