[
https://issues.apache.org/jira/browse/METRON-1114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16158572#comment-16158572
]
ASF GitHub Bot commented on METRON-1114:
----------------------------------------
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/702#discussion_r137763739
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/config/IndexConfig.java
---
@@ -56,8 +52,10 @@ public IndexDao indexDao() {
String hbaseProviderImpl =
environment.getProperty(MetronRestConstants.INDEX_HBASE_TABLE_PROVIDER_IMPL,
String.class, null);
String indexDaoImpl =
environment.getProperty(MetronRestConstants.INDEX_DAO_IMPL, String.class, null);
int searchMaxResults =
environment.getProperty(MetronRestConstants.SEARCH_MAX_RESULTS, Integer.class,
-1);
+ int searchMaxGroups =
environment.getProperty(MetronRestConstants.SEARCH_MAX_GROUPS, Integer.class,
1000);
--- End diff --
Why do we say SEARCH_MAX_RESULTS grabs a default of -1, but
SEARCH_MAX_GROUPS grabs a default of 1000? I'd be inclined to make them
consistent.
> Add group by capabilities to search REST endpoint
> -------------------------------------------------
>
> Key: METRON-1114
> URL: https://issues.apache.org/jira/browse/METRON-1114
> Project: Metron
> Issue Type: New Feature
> Reporter: Ryan Merriman
> Assignee: Ryan Merriman
>
> We need a way to group search results. Instead of all search results being
> included in a single list, they would instead be grouped together based a
> list of fields. For example, if "ip_src_addr" was set to the groupBy field,
> all results with the same value for that field would be in a group together.
> All other search features would still apply to the groups including
> filtering, sorting and result set size.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)