[
https://issues.apache.org/jira/browse/METRON-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16252680#comment-16252680
]
ASF GitHub Bot commented on METRON-1289:
----------------------------------------
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/824
The latest commit fixes the group by bug found by @iraghumitra and
addresses the feedback
[above](https://github.com/apache/metron/pull/824#pullrequestreview-76466048).
The group by fix was simple. We are now just excluding the "metaalert"
sensor type from group by queries.
Refactoring the HBaseDao was more involved. One of the side effects of
storing the sensorType in the row key is that now we require a map of guids to
sensorTypes for an IndexDao.getAllLatest call. These means the
IndexDao.getAllLatest interface needed to change. It made sense to just create
a standard interface that can be used for looking up records since it is used
in many different places and can be confusing as to what is needed to perform
an operation on a document. So this PR introduces a GetRequest that has the
following structure:
```
{
"guid": "some guid",
"sensorType" : " some sensor type",
"index": "some optional index, not required"
}
```
Since now keep the sensorType in the row key it is required for a look up.
HBase still doesn't have any concept of an index so that is kept optional. In
the ElasticsearchDao this is handled by using the index of a GetRequest if
present or looking it up in Elasticsearch if not. Now it should be clear what
is needed to get a document since the interface is more consistent across that
DAO methods.
Because of the GetRequest change the testing process and REST interface has
changed slightly. The PR description has been updated to reflect the changes.
I am still planning on doing a fresh vagrant build but this should be ready for
testing.
> Alert fields are lost when a MetaAlert is created
> -------------------------------------------------
>
> Key: METRON-1289
> URL: https://issues.apache.org/jira/browse/METRON-1289
> Project: Metron
> Issue Type: Bug
> Reporter: Ryan Merriman
> Assignee: Ryan Merriman
>
> When a MetaAlert is created, the included results are being updated
> incorrectly with only the "metaalert" field. This causes subsequent findOne
> operations to only return the "metaalert field for that alert. All fields
> should continue to be present.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
