[
https://issues.apache.org/jira/browse/METRON-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16341097#comment-16341097
]
ASF GitHub Bot commented on METRON-1392:
----------------------------------------
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/892
+1 by inspection. Thanks for fixing this @MohanDV. The original test
didn't even make sense.
> Fix a test case to expect an Exception when replication factor more than
> number of brokers while creating topic
> ---------------------------------------------------------------------------------------------------------------
>
> Key: METRON-1392
> URL: https://issues.apache.org/jira/browse/METRON-1392
> Project: Metron
> Issue Type: Bug
> Reporter: Mohan
> Assignee: Mohan
> Priority: Minor
>
> KafkaServiceImplTest.createTopicShouldFailIfReplicationFactorIsGreaterThanAvailableBrokers()
> is suppose to test create topic with replication factor more than number of
> brokers, which is expected to throw exception, but the test case doesn't
> expect exception and neither mocked to throw exception when the replication
> factor is greater than number of brokers.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)