[ https://issues.apache.org/jira/browse/METRON-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427217#comment-16427217 ]
ASF GitHub Bot commented on METRON-1512: ---------------------------------------- GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/983 METRON-1512 Refactor CONFIG_GET/CONFIG_PUT to Use ZKConfigurationsCache NOTE: This depends on #982 and should not be merged until #982. Currently the `ConfigurationFunctions` like `CONFIG_GET` and `CONFIG_PUT` use their own Zookeeper caching implementation. We have since implemented a reusable cache implementation `ZkConfigurationsCache`. These functions should use it. ### Changes 1. The `ConfigurationsFunctions` now uses `ZkConfigurationsCache`. 1. There are now additional unit tests covering these functions. ## Pull Request Checklist - [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [ ] Have you included steps or a guide to how the change may be verified and tested manually? - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: - [ ] Have you written or updated unit tests and or integration tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? You can merge this pull request into a Git repository by running: $ git pull https://github.com/nickwallen/metron METRON-1512 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/983.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #983 ---- commit 4801bffb45649501f4c51f197de4dc8a10953e08 Author: Nick Allen <nick@...> Date: 2018-04-04T19:29:26Z METRON-1511 Unable to Serialize Profiler Configuration commit 1eab0a853722ac4a2cecee018390066457398fc0 Author: Nick Allen <nick@...> Date: 2018-04-04T20:57:16Z METRON-1512 Refactor CONFIG_GET/CONFIG_PUT to Use ZKConfigurationsCache ---- > Refactor CONFIG_GET/CONFIG_PUT to Use ZKConfigurationsCache > ----------------------------------------------------------- > > Key: METRON-1512 > URL: https://issues.apache.org/jira/browse/METRON-1512 > Project: Metron > Issue Type: Improvement > Reporter: Nick Allen > Assignee: Nick Allen > Priority: Minor > > Currently the `ConfigurationFunctions` like `CONFIG_GET` and `CONFIG_PUT` use > their own Zookeeper caching implementation. We have since implemented a > reusable cache implementation `ZkConfigurationsCache`. These functions > should use it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)