GitHub user sardell opened a pull request:
https://github.com/apache/metron/pull/1010
METRON-1548: Remove hardcoded source:type from Alerts UI
## Contributor Comments
Instead of 'source:type' being hard coded as a string in the Alerts UI, we
now use a global-config service to retrieve whether a user's setup is using
"source:type" or "source.type" syntax (e.g. elastic search or solr). The app
default's to using "source:type" if no configuration is specified. If a user
wants, they can update their configuration to use source.type by adding
`"sourceType": "source.type"` to their configuration.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [ ] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified
and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install &&
dev-utilities/build-utils/verify_licenses.sh
```
- [ ] Have you written or updated unit tests and or integration tests to
verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sardell/metron METRON-1548
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1010.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1010
----
commit 1f6edee9a8a9a2b83072408a5089f1b95b35bb4b
Author: Shane Ardell <sardell@...>
Date: 2018-05-07T11:19:42Z
remove hard-coded source:type and replace with env variable
commit c37d23988a6466256512c7417d855fc15af0b065
Author: Shane Ardell <sardell@...>
Date: 2018-05-11T12:20:51Z
get config from API instead of a environment file
commit be59b8e7e8f5abfd1ab3edf21658695e4cd4e46e
Author: Shane Ardell <sardell@...>
Date: 2018-05-11T13:32:56Z
remove unused facet and group constants
commit ec68878b96d8831e03299d19c8daf7cef7f3104b
Author: Shane Ardell <sardell@...>
Date: 2018-05-11T13:34:41Z
use global config to set source type in update service
commit e8935077f779cbffcc35400014cf24d6bf0e2de5
Author: Shane Ardell <sardell@...>
Date: 2018-05-11T13:37:23Z
remove sourceType var from environment file
----
---
