[ 
https://issues.apache.org/jira/browse/METRON-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472829#comment-16472829
 ] 

ASF GitHub Bot commented on METRON-1552:
----------------------------------------

Github user cestella commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1011#discussion_r187757615
  
    --- Diff: 
metron-platform/metron-data-management/src/main/java/org/apache/metron/dataloads/nonbulk/geo/GeoEnrichmentLoader.java
 ---
    @@ -146,7 +156,14 @@ protected void loadGeoIpDatabase(CommandLine cli) 
throws IOException {
         System.out.println("Retrieving GeoLite2 archive");
         String url = GeoEnrichmentOptions.GEO_URL.get(cli, 
"http://geolite.maxmind.com/download/geoip/database/GeoLite2-City.mmdb.gz";);
         String tmpDir = GeoEnrichmentOptions.TMP_DIR.get(cli, "/tmp") + "/"; 
// Make sure there's a file separator at the end
    -    File localGeoFile = downloadGeoFile(url, tmpDir);
    +    int numRetries = 
Integer.parseInt(GeoEnrichmentOptions.RETRIES.get(cli, "2"));
    --- End diff --
    
    can we make "2" a constant?


> Add gzip file validation check to the geo loader
> ------------------------------------------------
>
>                 Key: METRON-1552
>                 URL: https://issues.apache.org/jira/browse/METRON-1552
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Michael Miklavcic
>            Assignee: Michael Miklavcic
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to