[ https://issues.apache.org/jira/browse/METRON-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16474169#comment-16474169 ]
ASF GitHub Bot commented on METRON-1065: ---------------------------------------- GitHub user basvdl reopened a pull request: https://github.com/apache/metron/pull/670 METRON-1065 grok pattern for cisco asa parser expects syslog pri ## Contributor Comments Cisco ASA logs does not always contain a priority code at the beginnen of the event. Therefore I've changed the grok pattern to make this optional. `<164>Aug 05 2016 01:01:34: %ASA-4-106023: Deny tcp src Inside:10.30.9.121/54580 dst Outside:192.168.135.51/42028 by access-group "Inside_access_in" [0x962df600, 0x0]` <164> should be optional. ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [ ] Have you included steps or a guide to how the change may be verified and tested manually? - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && build_utils/verify_licenses.sh ``` - [x] Have you written or updated **unit tests** and or integration tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` #### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/basvdl/metron METRON-1065_Grok_pattern_for_Cisco_ASA_Parser_expects_syslog_pri Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/670.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #670 ---- commit c691e3374ea9e9bdb4c291071adae045516e744b Author: Bas van de Lustgraaf <bas.van.de.lustgraaf@...> Date: 2017-07-26T14:04:05Z Priority for Cisco ASA logging is optional commit a731004e53b948979bdbb6d01bdd274702eef0c7 Author: Bas van de Lustgraaf <bas.van.de.lustgraaf@...> Date: 2017-07-26T14:10:14Z Fixed formatting commit 69584cdee5098bcc6449c72f5a69129e20c23cd8 Author: Bas van de Lustgraaf <bas.van.de.lustgraaf@...> Date: 2017-07-26T14:18:04Z Fix the license header after using the intelliJ auto format ---- > Grok pattern for Cisco ASA Parser expects syslog_pri > ---------------------------------------------------- > > Key: METRON-1065 > URL: https://issues.apache.org/jira/browse/METRON-1065 > Project: Metron > Issue Type: Improvement > Affects Versions: 0.4.1 > Reporter: Bas van de Lustgraaf > Priority: Minor > > The current grok pattern `CISCO_TAGGED_SYSLOG` expects to have a syslog > priority present at the start of each message. Unfortunately, this is not > always the case. > *Currently supported:* > {noformat} > <162>Aug 05 2016 01:02:25: %ASA-2-106006: Deny inbound UDP from > 10.25.177.164/63279 to 10.2.52.71/161 on interface Inside > {noformat} > *Not supported by the current Grok pattern:* > {noformat} > Aug 05 2016 01:02:25: %ASA-2-106006: Deny inbound UDP from > 10.25.177.164/63279 to 10.2.52.71/161 on interface Inside > {noformat} > My suggestion would be to edit the `CISCO_TAGGED_SYSLOG` pattern to make the > following part optional: > {noformat} > <%{POSINT:syslog_pri}> > {noformat} > And grep the severity from the `%ASA-4-106023` part. The part between the > hyphens, is the severity (source > http://www.cisco.com/c/en/us/td/docs/security/asa/syslog/b_syslog/syslogs-sev-level.html). -- This message was sent by Atlassian JIRA (v7.6.3#76005)