GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/1018
METRON-1566: Alert updates are not propagated to metaalert child alerts
## Contributor Comments
Updates to alerts will now be reflected in metaalert child alerts. This
was caused by the ElasticsearchMetaAlertDao class calling the update method on
IndexDao directly rather than calling it's own update method. Steps to
reproduce:
1. Find an alert.
```
curl -u user:password -X POST --header 'Content-Type: application/json'
--header 'Accept: application/json' -d '{
"fields": [
"guid"
],
"from": 0,
"indices": [
"snort"
],
"query": "*",
"size": 1
}' 'http://node1:8082/api/v1/search/search'
```
2. Create a metaalert from the alert in step 1.
```
curl -u user:password -X POST --header 'Content-Type: application/json'
--header 'Accept: application/json' -d '{
"alerts": [
{
"guid": "dc4abb51-3b7e-4875-b3af-a03b5fd783d9",
"index": "snort",
"sensorType": "snort"
}
],
"groups": [
"test"
]
}' 'http://node1:8082/api/v1/metaalert/create'
```
3. Update the original alert.
```
curl -u user:password -X PATCH --header 'Content-Type: application/json'
--header 'Accept: application/json' -d '{
"guid": "dc4abb51-3b7e-4875-b3af-a03b5fd783d9",
"index": "snort",
"patch": [
{
"op": "add"
, "path": "/newField"
, "value": "value"
}
],
"sensorType": "snort"
}' 'http://node1:8082/api/v1/update/patch'
```
4. Verify the change was applied to the alert. The "newField" field should
be present.
```
curl -u user:password -X POST --header 'Content-Type: application/json'
--header 'Accept: application/json' -d '{
"guid": "dc4abb51-3b7e-4875-b3af-a03b5fd783d9",
"index": "snort",
"sensorType": "snort"
}' 'http://node1:8082/api/v1/search/findOne'
```
5. Verify the change was also applied to the child alert in the metaalert.
The "newField" field should also be present in the child alert.
```
curl -u user:password -X POST --header 'Content-Type: application/json'
--header 'Accept: application/json' -d '{
"guid": "a76e0bae-4420-4f31-b2b3-234cd9fb9e60",
"index": "metaalert",
"sensorType": "metaalert"
}' 'http://node1:8082/api/v1/search/findOne'
```
I hit another bug when testing that resulted from timestamp being set to 0
when updating metaalert objects. Since it was keeping this use case from
working I added the fix to this PR. I also added a change to HBaseDao to guard
against this in the future and a test to go with it.
I verified this in full dev.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install &&
dev-utilities/build-utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/merrimanr/incubator-metron METRON-1566
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1018.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1018
----
commit 3a6a2f32782e17dc1ec36d1c9e8487cb19aa5bbd
Author: merrimanr <merrimanr@...>
Date: 2018-05-16T19:43:15Z
initial commit
----
---
