[
https://issues.apache.org/jira/browse/METRON-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496619#comment-16496619
]
ASF GitHub Bot commented on METRON-1590:
----------------------------------------
GitHub user justinleet opened a pull request:
https://github.com/apache/metron/pull/1041
METRON-1590: validate-jira-for-release script checks out project into
current directory not workdir
## Contributor Comments
Altering the script a bit. Note that you can't just `git clone git clone
$REPO "$WORKDIR/metron-$VERSION"` while leaving `WORKDIR="~/tmp"` because git
clone is always relative to current dir and you'll end up with a new folder
named `~`.
Also moved `WORKDIR` down to where it's actually used for clarity, since it
gets created earlier than it needs to be.
To test, run `./validate-jira-for-release --version=0.5.0
--start=tags/apache-metron-0.4.2-release` and ensure that the checkout occurs
in `~/tmp/metron-0.5.0`, rather than in current directory.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root metron
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/justinleet/metron validateJiraDir
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1041.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1041
----
commit 4ea61cbd7ed314a1a40fb1d897fe95ad38cd0e25
Author: justinjleet <justinjleet@...>
Date: 2018-05-31T14:12:19Z
fixing move to ~/tmp
----
> validate-jira-for-release script checks out project into current directory
> not workdir
> --------------------------------------------------------------------------------------
>
> Key: METRON-1590
> URL: https://issues.apache.org/jira/browse/METRON-1590
> Project: Metron
> Issue Type: Bug
> Reporter: Justin Leet
> Assignee: Justin Leet
> Priority: Major
>
> validate-jira-for-release at
> [https://github.com/apache/metron/blob/master/dev-utilities/release-utils/validate-jira-for-release#L165-L168]
> The clone checks out into current dir, so `$WORKDIR/metron-$VERSION` never
> gets created. However, since the `cd` fails, we stay in the working dir, and
> the script happens to work.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
