GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/1043
METRON-1587: Make collection utility work for HDP search
## Contributor Comments
This PR improves the metron-solr create_collection.sh and
delete_collection.sh scripts by switching to the Solr REST api instead of the
Solr CLI tools. This removes the requirement that Metron is colocated with a
Solr client and makes the scripts easier to use with different versions and
distributions. Now only a zookeeper client is required for retrieving a Solr
node address.
I refactored the Ambari code a little bit to match the rest of our MPack.
The solr_schema_install and
solr_schema_delete functions were moved from indexing_master.py to
indexing_commands.py because specific, low-level functions are generally in the
*_commands.py scripts. If this is confusing, doesn't make sense or makes
reviewing this harder I'm happy to move them back.
I also added Kerberos support to these scripts. The way I've done it
creates a dependency on the HDP Search 3 Mpack but makes configuring Kerberos
easy with no configuration required. I would like to hear what the community
thinks about this approach. If we do decide to make this a dependency I can
also remove the Solr zookeeper configuration setting in Ambari. At that point
using Solr is as easy as switching the "Random Access Search Engine" setting.
This has been tested in full dev with Kerberos enabled. To test this PR,
first install HDP Search 3 in full dev
(https://docs.hortonworks.com/HDPDocuments/HDP2/HDP-2.6.4/bk_solr-search-installation/content/hdp-search30-install-mpack.html).
Kerberos can also be enabled now if desired. Then in Ambari set "Solr
Zookeeper Urls" in the "Index Settings" tab to `node1:2181/solr` and change the
"Random Access Search Engine" setting in the Indexing tab to `Solr`. Now stop
the Metron Indexing component, then start it. Note that restart does not
trigger automatic Solr collection creation, matching how ES template loading
works. If we think adding collection creation on restart is desirable I can
make that change. Collections (bro, snort, metaalert, yaf, error) should now
be present in Solr at node1:8983.
The scripts can also be tested independently from Ambari. Just have to set
a few environment variables first:
```
export ZOOKEEPER=node1:2181/solr
export SECURITY_ENABLED=true # if Kerberos is enabled
```
Then the scripts should work when executed directly. For example, to
create the bro collection:
```
$METRON_HOME/bin/create_collection.sh bro
```
and to delete the bro collection:
```
$METRON_HOME/bin/delete_collection.sh bro
```
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install &&
dev-utilities/build-utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/merrimanr/incubator-metron METRON-1587
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1043.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1043
----
commit 3aaf046d1ffab965a551993f7eafa4dd571f5a06
Author: merrimanr <merrimanr@...>
Date: 2018-05-30T21:40:07Z
initial commit
----
---
