[GitHub] metron pull request #1055: METRON-1608: Add configuration for threat.triage....

[nickwallen]

Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1055#discussion_r193850059
  
    --- Diff: 
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/SearchServiceImpl.java
 ---
    @@ -151,7 +152,7 @@ public GroupResponse group(GroupRequest groupRequest) 
throws RestException {
           String sourceTypeField = Constants.SENSOR_TYPE.replace('.', ':');
    --- End diff --
    
    Just another point of duplication.  We define what the default value is 
here and in `ElasticsearchMetaAlertDao`.  Could be extracted out along with the 
other bits.


---