GitHub user cestella opened a pull request: https://github.com/apache/metron/pull/1064
METRON-1619: Stellar empty collections should be considered false in boolean expressions ## Contributor Comments Similar to #1063 we should consider empty collections and maps as falsey. This PR builds on #1063, so it should be merged after. You can test this in the REPL similar to #1063 except substituting `[]` for `is_alert`. ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [x] Have you included steps or a guide to how the change may be verified and tested manually? - [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - [x] Have you written or updated unit tests and or integration tests to verify your changes? - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` #### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cestella/incubator-metron stellar_empty_lists_falsey Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/1064.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1064 ---- commit fc215e76500a23b1da20ae189a2f5db35c076786 Author: cstella <cestella@...> Date: 2018-06-16T16:31:35Z Make false be null in boolean expressions commit 95929c072798e0700231657903f12e0590280890 Author: cstella <cestella@...> Date: 2018-06-16T16:33:29Z additional tests commit 32e1f1e2fe7ed18a307defebcb6c9db8972209f5 Author: cstella <cestella@...> Date: 2018-06-16T17:20:02Z Stellar empty lists in boolean expressions should be considered false commit 74194408bdcf05eaabb932d1b1f162ddd607bf35 Author: cstella <cestella@...> Date: 2018-06-16T17:26:18Z Updating falsey ---- ---