[
https://issues.apache.org/jira/browse/METRON-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533815#comment-16533815
]
ASF GitHub Bot commented on METRON-1651:
----------------------------------------
GitHub user tiborm opened a pull request:
https://github.com/apache/metron/pull/1095
METRON-1651: Fixing faIling protractor e2e tests
## Contributor Comments
The PR contains fixes for METRON-1651 and some small improvements stabilize
protractor tests.
- alert-details-status test had to be ignored till wi fix the bug behind
the test failure (related ticket linked)
- two assertation has to be commented out because of the same bug (related
ticket linked)
- one assertation added back, the issue behind it fixed
- browser.sleep added in two places to reduce test flakiness
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [ ] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified
and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install &&
dev-utilities/build-utils/verify_licenses.sh
```
- [ ] Have you written or updated unit tests and or integration tests to
verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tiborm/metron METRON-1651
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1095.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1095
----
commit c0b6a994c8011f9dcfaf1fff5cb5c205d808049e
Author: tiborm <tibor.meller@...>
Date: 2018-07-04T11:24:03Z
METRON-1651: ignoring tests fails by a know issue
commit dafd0fd2aa90c24986869aeb297519e92203f30a
Author: tiborm <tibor.meller@...>
Date: 2018-07-05T09:44:47Z
METRON-1651: linking faling assertations to the related bug ticket
commit d40310da038ab0aad2e2dbd7486bcbf69911ebff
Author: tiborm <tibor.meller@...>
Date: 2018-07-05T14:40:17Z
METRON-1651: adding custom matchers in beforeAll
commit e1160b040ad386d2535ecf3a9cf16297222aa4fb
Author: tiborm <tibor.meller@...>
Date: 2018-07-05T14:43:59Z
METRON-1651: jira ticket #1631 fixed - assertation passing; adding sleep to
reduce test flakiness
commit 35036146d0f5be025a3db53ee2ba46d098c1bdc8
Author: tiborm <tibor.meller@...>
Date: 2018-07-05T14:45:35Z
METRON-1651: fixing changed alert order caused by test data modifications
commit 02d679767cc3ca44bf50fda0c79bce7e29897a17
Author: tiborm <tibor.meller@...>
Date: 2018-07-05T14:46:34Z
METRON-1631: adding sleep to reduce test flakiness
----
> Fixing failing protractor e2e test
> ----------------------------------
>
> Key: METRON-1651
> URL: https://issues.apache.org/jira/browse/METRON-1651
> Project: Metron
> Issue Type: Bug
> Reporter: Tibor Meller
> Priority: Major
> Attachments: e2e-assertion-errors.png
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
