Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/1109#discussion_r203047410 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/config/PcapJobSupplier.java --- @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.metron.rest.config; + +import org.apache.hadoop.fs.Path; +import org.apache.metron.job.JobException; +import org.apache.metron.job.JobStatus; +import org.apache.metron.job.Statusable; +import org.apache.metron.pcap.finalizer.PcapFinalizerStrategies; +import org.apache.metron.pcap.mr.PcapJob; +import org.apache.metron.rest.model.pcap.PcapRequest; + +import java.util.function.Supplier; + +public class PcapJobSupplier implements Supplier<Statusable<Path>> { + + private PcapRequest pcapRequest; + + @Override + public Statusable<Path> get() { + try { + PcapJob<Path> pcapJob = createPcapJob(); + return pcapJob.submit(PcapFinalizerStrategies.REST, pcapRequest); + } catch (JobException e) { + return null; + //return new JobStatus().withState(JobStatus.State.FAILED).withDescription(JobStatus.State.FAILED.toString()); --- End diff -- Is this intended? Seems like we should be passing back info about the exception or at the very least throwing a runtime exception, right?
---