Github user merrimanr commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1122#discussion_r204552197
  
    --- Diff: metron-interface/metron-alerts/src/app/pcap/model/pcap.request.ts 
---
    @@ -0,0 +1,30 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing software
    + * distributed under the License is distributed on an "AS IS" BASIS
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +export class PcapRequest {
    +  startTimeMs: number = 0;
    +  endTimeMs: number = 0;
    +  ipSrcAddr: string = '';
    +  ipSrcPort: string = '';
    +  ipDstAddr: string = '';
    +  ipDstPort: string = '';
    +  protocol: string = '';
    +  packetFilter: string = '';
    +  includeReverse: boolean = false;
    +  from?: number;
    --- End diff --
    
    This property doesn't do anything and is ignored by the API.  It should be 
removed.


---

Reply via email to