Github user mmiklavc commented on the issue:

    https://github.com/apache/metron/pull/1132
  
    @anandsubbu, considering the changes in this PR:
    
    1. Let's say I manually make changes to `pcap.properties`. I restart the 
parser topologies. Later, I manually restart pcap with the shell command. What 
happens to my `pcap.properties` changes?
    2. Similarly, I make changes via Ambari's new PCAP panel. Now I go start 
pcap using `$METRON_HOME/bin/start_pcap_topology.sh`. What does pcap.properties 
look like?
    
    In 1, your changes are overwritten by the parsers' restart. In 2, you've 
made changes in Ambari but they don't get materialized in the properties file 
because you haven't restarted the parsers - I may be mistaken, but I'm pretty 
sure clicking "save" in Ambari does not deploy the new properties, and this is 
the reason I ask for a doc change. Previously, configuring pcap was all manual 
steps. Now it will be a combo of manual steps for start/stop, automated steps 
for the config updates. And more specifically for the config updates, you will 
*only* see them if you make them in Ambari and restart the parsers. Also, if 
you choose not to use Ambari for this config handling and instead make your 
config changes to pcap.properties locally, you will have to remember that 
restarting the parsers will overwrite your pcap config - something you're only 
likely to realize the next time you start/restart pcap. This is the behavior 
that I think we should document if we accept this. Does that make s
 ense?


---

Reply via email to