[
https://issues.apache.org/jira/browse/METRON-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16573587#comment-16573587
]
ASF GitHub Bot commented on METRON-1720:
----------------------------------------
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/1154#discussion_r208675839
--- Diff:
metron-interface/metron-alerts/src/app/pcap/service/pcap.service.ts ---
@@ -56,8 +56,7 @@ export class PcapService {
public getPackets(id: string, pageId: number): Observable<Pdml> {
return this.http.get(`/api/v1/pcap/${id}/pdml?page=${pageId}`, new
RequestOptions({headers: new Headers(this.defaultHeaders)}))
.map(HttpUtil.extractData)
- .catch(HttpUtil.handleError)
- .onErrorResumeNext();
--- End diff --
It won't catch the error if that line is included.
> Better error messages when there are no results or wireshark is not installed
> -----------------------------------------------------------------------------
>
> Key: METRON-1720
> URL: https://issues.apache.org/jira/browse/METRON-1720
> Project: Metron
> Issue Type: Sub-task
> Reporter: Ryan Merriman
> Assignee: Ryan Merriman
> Priority: Major
>
> We should report why pcap data cannot be retrieved in pdml format after a
> query has run.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
