Github user mmiklavc commented on a diff in the pull request:
https://github.com/apache/metron/pull/1153#discussion_r208773887
--- Diff:
metron-platform/metron-pcap-backend/src/test/java/org/apache/metron/pcap/query/PcapCliTest.java
---
@@ -112,7 +120,24 @@ public void
runs_fixed_pcap_filter_job_with_default_argument_list() throws Excep
return new TypeSafeMatcher<Map<K, V>>() {
@Override
protected boolean matchesSafely(Map<K, V> item) {
- return item.entrySet().containsAll(map.entrySet());
+ for(K key: map.keySet()) {
+ if (key.equals(PcapOptions.HADOOP_CONF.getKey())) {
+ Configuration itemConfiguration = (Configuration)
item.get(PcapOptions.HADOOP_CONF.getKey());
+ Map<String, Object> mapConfiguration = (Map<String, Object>)
map.get(PcapOptions.HADOOP_CONF.getKey());
+ for(String setting: mapConfiguration.keySet()) {
+ if
(!mapConfiguration.get(setting).equals(itemConfiguration.get(setting, ""))) {
+ return false;
+ }
+ }
+ } else {
+ V itemValue = item.get(key);
+ V mapValue = map.get(key);
+ if (itemValue != null ? !itemValue.equals(mapValue) : mapValue
== null) {
--- End diff --
Should this be `!(mapValue == null)`?
**Similarly stated:**
```
if (itemValue == null ? mapValue == null : itemValue.equals(mapValue)) {
return true;
}
```
If both values are null, it should return `true`, I would expect.
---
