[ 
https://issues.apache.org/jira/browse/METRON-1732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578574#comment-16578574
 ] 

ASF GitHub Bot commented on METRON-1732:
----------------------------------------

Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1157#discussion_r209665613
  
    --- Diff: 
metron-platform/metron-pcap/src/main/java/org/apache/metron/pcap/mr/PcapJob.java
 ---
    @@ -307,8 +307,11 @@ public void setCompleteCheckInterval(long interval) {
           }
           return this;
         }
    -    mrJob.submit();
    -    jobStatus.withState(State.SUBMITTED).withDescription("Job 
submitted").withJobId(mrJob.getJobID().toString());
    +    synchronized (this) {
    --- End diff --
    
    Can we add a comment about why we need the lock here?


> Fix job status liveness bug and parallelize finalizer file writing
> ------------------------------------------------------------------
>
>                 Key: METRON-1732
>                 URL: https://issues.apache.org/jira/browse/METRON-1732
>             Project: Metron
>          Issue Type: Sub-task
>            Reporter: Michael Miklavcic
>            Assignee: Michael Miklavcic
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to