Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/1159#discussion_r209698673
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.ts
---
@@ -63,9 +63,13 @@ export class PcapFiltersComponent implements OnInit,
OnChanges {
this.model.endTimeMs = new Date(this.endTimeStr).getTime();
if (this.ipSrcPort !== '') {
this.model.ipSrcPort = +this.ipSrcPort;
+ } else {
--- End diff --
They are different types, one is a string and one is a number. I believe
we created the this.ipSrcPort and this.ipDstPort string variables for regex
validation purposes. As such we can't just assign an empty string to a number
type. The + operator converts a string to a number.
---
