[
https://issues.apache.org/jira/browse/METRON-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604923#comment-16604923
]
ASF GitHub Bot commented on METRON-1717:
----------------------------------------
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/1187
METRON-1717 Relocate Storm Profiler Code
- This change moves the Storm Profiler module to
`metron-analytics/metron-profiler-storm`.
- The core Storm Profiler package was renamed to
`org.apache.metron.profiler.storm`.
- All of the Profiler READMEs have been cleaned-up to contain only content
relevant to each project. The main README is now in
`metron-analytics/metron-profiler-common` which links to the others as needed.
## Testing
1. Stand-up a development environment.
1. Validate the development environment by ensuring alerts are visible
within the Alerts UI and that the Metron Service Check in Ambari passes.
1. Launch the REPL and follow the instructions in the Profiler README to
[create and execute a profile in the
REPL](https://github.com/apache/metron/tree/master/metron-analytics/metron-profiler#creating-profiles).
1. Follow the instructions in the README to[ deploy the same profile in
Storm](https://github.com/apache/metron/tree/master/metron-analytics/metron-profiler-storm#getting-started).
Ensure that you can retrieve values from HBase using `PROFILE_GET`.
1. Generate the site book and review the READMEs that have changed.
```
cd site-book
mvn site
```
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified
and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
- [ ] Have you written or updated unit tests and or integration tests to
verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nickwallen/metron METRON-1717
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1187.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1187
----
commit 290bc793a4cecb1c7c83ef4cfb77f67f5ef7dbbe
Author: Nick Allen <nick@...>
Date: 2018-09-05T16:12:51Z
METRON-1717 Renamed Storm Profiler package
commit b88c0e72974480750255d6e64faed24cf876527b
Author: Nick Allen <nick@...>
Date: 2018-09-05T17:15:46Z
Rename package to org.apache.metron.profiler.storm
commit 27e69d41c2e8a982dca23dfc6feca737b0e48c12
Author: Nick Allen <nick@...>
Date: 2018-09-05T20:36:26Z
Updated READMEs
----
> Relocate Storm Profiler Code
> ----------------------------
>
> Key: METRON-1717
> URL: https://issues.apache.org/jira/browse/METRON-1717
> Project: Metron
> Issue Type: Sub-task
> Reporter: Nick Allen
> Priority: Major
>
> The Storm port of the Profiler currently lives in
> metron-analytics/metron-profiler. This should be moved to
> metron-analytics/metron-profiler-storm. This would mirror the project names
> for the Spark port (metron-profiler-spark) and the REPL port
> (metron-profiler-repl).
> The package name for the Storm port of the Profiler should be changed to
> org.apache.metron.profiler.storm. This would mimic the package name used for
> Spark; org.apache.metron.profiler.spark.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
