[ 
https://issues.apache.org/jira/browse/METRON-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607692#comment-16607692
 ] 

ASF GitHub Bot commented on METRON-1771:
----------------------------------------

Github user merrimanr commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1190#discussion_r216092562
  
    --- Diff: 
metron-platform/metron-indexing/src/test/java/org/apache/metron/indexing/dao/metaalert/MetaAlertIntegrationTest.java
 ---
    @@ -985,6 +1024,30 @@ protected boolean findCreatedDocs(List<GetRequest> 
getRequests)
         throw new OriginalNotFoundException("Count not find guids after " + 
MAX_RETRIES + "tries");
       }
     
    +  @SuppressWarnings("unchecked")
    +  protected void assertEquals(Map<String, Object> expected, Map<String, 
Object> actual) {
    --- End diff --
    
    This method is needed to handle type mismatches (Integer to Long and Float 
to Double) and child alert ordering.
     These fields are not defined in the metaalert template so ES is guessing 
the type.  When read back some field types are different vs when they were 
written.


> Update REST endpoints to support eventually consistent UI updates
> -----------------------------------------------------------------
>
>                 Key: METRON-1771
>                 URL: https://issues.apache.org/jira/browse/METRON-1771
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Ryan Merriman
>            Priority: Major
>
> Currently the REST endpoints that perform document updates either return 
> true/false or nothing.  This puts the responsibility of retrieving the 
> updated state of the object on the client in a separate call or 
> optimistically applying the changes and reverting when an update fails.  This 
> can be problematic if a client attempts to get the current state immediately 
> after an update and the change isn't visible yet in the back end.
> Ideally they should return the updated state of the object, eliminating the 
> need to look up the updated state in a separate call.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to