[ 
https://issues.apache.org/jira/browse/METRON-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641863#comment-16641863
 ] 

ASF GitHub Bot commented on METRON-1801:
----------------------------------------

Github user nickwallen commented on the issue:

    https://github.com/apache/metron/pull/1218
  
    > @mraliagha: So if es.document.id is not provided, as the default, doc id 
won't be send to ES indexing, right?
    
    Yes, exactly.  
    
    > @mraliagha: I guess it would be also nice to provide some guidance on how 
document ID should be defined (in the case of custom ID). Otherwise, users may 
create some serious issues with the indexing and search throughput.
    
    I am just providing the **capability** for advanced users to define their 
own doc ID, primarily based on your feedback in METRON-1677.  (It also provides 
a nice way to support backwards compatibility, which is the main reason that I 
took this approach.) 
    
    If you have any advice to offer, feel free to offer it and we can include 
it in the docs.  Other than that, I am not sure what I can do besides add a 
big, bold warning to the docs that says create your own doc ID at your own risk.



> Allow Customization of Elasticsearch Document ID
> ------------------------------------------------
>
>                 Key: METRON-1801
>                 URL: https://issues.apache.org/jira/browse/METRON-1801
>             Project: Metron
>          Issue Type: Sub-task
>            Reporter: Nick Allen
>            Assignee: Nick Allen
>            Priority: Major
>
> The user should be able to customize the document ID that is set by the 
> client when indexing documents into Elasticsearch.  The user should be able 
> to use the Metron GUID, define their own custom document ID, or choose to not 
> have the document ID set by the client.
>  
> This task covers Elasticsearch only.  An additional task should be created to 
> cover Solr.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to