Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1219#discussion_r223498638
  
    --- Diff: metron-interface/metron-alerts/package.json ---
    @@ -22,17 +22,17 @@
         "@angular/platform-browser": "^6.1.6",
         "@angular/platform-browser-dynamic": "^6.1.6",
         "@angular/router": "^6.1.6",
    +    "@ruffle1986/pikaday-time": "^1.6.1",
         "@types/bootstrap": "^4.1.1",
         "@types/jquery": "^3.3.4",
         "ace-builds": "^1.2.6",
         "ajv": "^6.5.1",
         "angular-confirmation-popover": "^4.2.0",
         "bootstrap": "4.0.0-alpha.6",
         "core-js": "^2.4.1",
    +    "date-fns": "^1.29.0",
         "font-awesome": "^4.7.0",
    -    "moment": "^2.22.2",
         "ng2-dragula": "^1.5.0",
    -    "pikaday-time": "^1.6.1",
    --- End diff --
    
    @ruffle1986 Your [PR](https://github.com/owenmead/Pikaday/issues/60) is 
unlikely to be accepted.  The author has marked 
[@owenmean/pikeday](https://github.com/owenmead/pikaday) as deprecated.
    
    IMO, I'd prefer us to just tackle option 1 first.  Let's find a long-term 
replacement for @owenmean/pikeday that has broader community support and is not 
deprecated. After that, we can come back to Moment.js.



---

Reply via email to