[ https://issues.apache.org/jira/browse/METRON-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16643535#comment-16643535 ]
ASF GitHub Bot commented on METRON-1796: ---------------------------------------- Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/1219#discussion_r223733562 --- Diff: metron-interface/metron-alerts/package.json --- @@ -22,17 +22,17 @@ "@angular/platform-browser": "^6.1.6", "@angular/platform-browser-dynamic": "^6.1.6", "@angular/router": "^6.1.6", + "@ruffle1986/pikaday-time": "^1.6.1", "@types/bootstrap": "^4.1.1", "@types/jquery": "^3.3.4", "ace-builds": "^1.2.6", "ajv": "^6.5.1", "angular-confirmation-popover": "^4.2.0", "bootstrap": "4.0.0-alpha.6", "core-js": "^2.4.1", + "date-fns": "^1.29.0", "font-awesome": "^4.7.0", - "moment": "^2.22.2", "ng2-dragula": "^1.5.0", - "pikaday-time": "^1.6.1", --- End diff -- @ruffle1986 I agree with @nickwallen. I'd rather see us fix this fully than get 90% there and need to address a follow-on for it. Seeing as the point of this improvement is intended to improve the stability and maintainability of the UI, I think it makes sense to solve the whole problem in this case. > [UI] Migrate off moment.js > -------------------------- > > Key: METRON-1796 > URL: https://issues.apache.org/jira/browse/METRON-1796 > Project: Metron > Issue Type: Improvement > Reporter: Tamas Fodor > Assignee: Tamas Fodor > Priority: Minor > > Remove Moment.js and replace with another smaller library. > Moment.js requires us to import the entire library vs. a few necessary > modules. > Moment.js can prevent bundlers from supporting tree-shaking. > By removing Moment.js, we can decrease our overall bundle size and prevent > issues with tree-shaking in the future. > Here you can find the discussion on the mailing list: > https://lists.apache.org/thread.html/2e4fafa4256ce14ebcd4433420974e24962884204418ade51f0e3bfb@%3Cdev.metron.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)