Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1218#discussion_r224539451 --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/writer/ElasticsearchWriterConfig.java --- @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.metron.elasticsearch.writer; + +import org.apache.metron.common.Constants; +import org.apache.metron.stellar.common.utils.ConversionUtils; + +import java.util.Map; + +/** + * Configuration settings that customize the behavior of the {@link ElasticsearchWriter}. + */ +public enum ElasticsearchWriterConfig { + + /** + * Defines which message field, the document identifier is set to. + * + * <p>If defined, the value of the specified message field is set as the Elasticsearch doc ID. If + * this field is undefined or blank, then the document identifier is not set. + */ + DOC_ID_SOURCE_FIELD("es.document.id", "", String.class); --- End diff -- I didn't know we had `ConfigOption`. I will remove `ElasticsearchWriterConfig` for now. Then as a follow-on, I will do something similar, but reuse `ConfigOption`. Thanks for the pointer!
---