[
https://issues.apache.org/jira/browse/METRON-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655506#comment-16655506
]
ASF GitHub Bot commented on METRON-1829:
----------------------------------------
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1239#discussion_r226371234
--- Diff:
metron-platform/metron-writer/src/test/java/org/apache/metron/writer/BulkWriterComponentTest.java
---
@@ -161,9 +165,12 @@ public void
writeShouldThrowExceptionWhenHandleErrorIsFalse() throws Exception {
@Test
public void writeShouldProperlyHandleWriterException() throws Exception {
Throwable e = new Exception("test exception");
- MetronError error = new MetronError()
+ MetronError expectedError1 = new MetronError()
.withSensorType(Collections.singleton(sensorType))
-
.withErrorType(Constants.ErrorType.INDEXING_ERROR).withThrowable(e).withRawMessages(Arrays.asList(message1,
message2));
+
.withErrorType(Constants.ErrorType.INDEXING_ERROR).withThrowable(e).withRawMessages(Collections.singletonList(message1));
--- End diff --
Small nit. While we are in here, do you think it is easier to read with
newlines?
```suggestion
.withErrorType(Constants.ErrorType.INDEXING_ERROR)
.withThrowable(e)
.withRawMessages(Collections.singletonList(message1));
```
> Large Error Message Causes Slow Search Performance
> --------------------------------------------------
>
> Key: METRON-1829
> URL: https://issues.apache.org/jira/browse/METRON-1829
> Project: Metron
> Issue Type: Bug
> Reporter: Ryan Merriman
> Priority: Major
>
> Errors that occur during batch writes in the index topologies (batch and RA)
> are written to Elasticsearch as a single, large error message, with a field
> for each failed message. For example, if the batch size is 5000, a single
> error message will be created with 5000 fields `raw_message_0`,
> `raw_message_1`, .., `raw_message_4999`. With such large messages, searching
> the error index in Elasticsearch is excessively slow.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
