[
https://issues.apache.org/jira/browse/METRON-1830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656586#comment-16656586
]
ASF GitHub Bot commented on METRON-1830:
----------------------------------------
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1240#discussion_r226589952
--- Diff:
metron-interface/metron-alerts/src/app/alerts/alerts-list/table-view/table-view.component.ts
---
@@ -259,19 +259,25 @@ export class TableViewComponent implements OnInit,
OnChanges, OnDestroy {
}
deleteOneAlertFromMetaAlert($event, alert: Alert, metaAlertIndex:
number) {
- this.metronDialogBox.showConfirmationMessage('Do you wish to remove
the alert from the meta alert?').subscribe(response => {
- if (response) {
+ let confirmedSubscription = this.dialogService.confirm('Do you wish to
remove the alert from the meta alert?').subscribe(r => {
--- End diff --
I would use const here (and all the other places) too.
> Re-implement Alerts dialog box without jQuery
> ---------------------------------------------
>
> Key: METRON-1830
> URL: https://issues.apache.org/jira/browse/METRON-1830
> Project: Metron
> Issue Type: Bug
> Reporter: Shane Ardell
> Assignee: Shane Ardell
> Priority: Minor
>
> Currently, the dialog box class in both UIs directly manipulates the DOM with
> jQuery. This is problematic when using a framework like Angular because it
> causes a disconnect with how Angular handles and tracks DOM changes. We also
> don't take advantage of Angular's rendering engine.
> The dialog box can and should be implemented as a component and a singleton
> service (since we would never want to launch more than one modal at a time).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
