GitHub user mmiklavc opened a pull request:
https://github.com/apache/metron/pull/1252
METRON-1855: Make unified enrichment topology the default and deprecate
split-join
## Contributor Comments
https://issues.apache.org/jira/browse/METRON-1855
Deprecates the split-join topology in favor of the simpler, more performant
unified enrichment topology. Encompasses the following changes:
- The MPack is configured with the Unified topology as the new default
- Unified topology properties appear first in the Ambari Enrichment config
section and in the enrichment type dropdown.
- Documentation changed to emphasize the unified topology
- Performance docs make note of the split-join topology deprecation in
favor of the unified topology.
I'll make another note of it in the DISCUSS thread, but I think we should
make a goal of marking split-join deprecated in this upcoming release and
removing it altogether shortly thereafter.
DISCUSS thread -
https://lists.apache.org/thread.html/6cfc883de28a5cb41f26d0523522d4b93272ac954e5713c80a35675e@%3Cdev.metron.apache.org%3E
**Testing**
- Spin up full dev
- Verify that the unified enrichment topology is now running by default.
- View the Storm UI topology details for enrichment and verify that there
is no longer a split/join bolt.
- Verify the unified enrichment properties show up first under the
enrichments config section and that "unified" is active in the enrichment type
dropdown.
- Change enrichment type to Split Join and verify that the deprecated
topology is still able to be run.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install &&
dev-utilities/build-utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- n/a If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mmiklavc/metron deprecate-split-join
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1252.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1252
----
commit 25e2b657b8f077006cabd1f79d1e7bb2aea28b13
Author: Michael Miklavcic <michael.miklavcic@...>
Date: 2018-11-03T22:11:44Z
Make unified enrichment topology new default. Deprecated split-join
topology.
----
---
