Github user nickwallen commented on a diff in the pull request:

    
https://github.com/apache/metron-bro-plugin-kafka/pull/15#discussion_r232298989
  
    --- Diff: README.md ---
    @@ -50,7 +51,7 @@ The goal in this example is to send all HTTP and DNS 
records to a Kafka topic na
      * By defining `topic_name` all records will be sent to the same Kafka 
topic.
      * Defining `logs_to_send` will ensure that only HTTP and DNS records are 
sent. 
     ```
    -@load packages/metron-bro-plugin-kafka/Apache/Kafka
    +@load 
'PathToDirContainingTheDownloadedMetronPlugin'/metron-bro-plugin-kafka/scripts/Apache/Kafka
    --- End diff --
    
    These examples are intended to be defined within a location in your Bro 
installation like `${BRO_HOME}/share/bro/site/local.bro`.  And this has to 
occur after you install the plugin in your Bro instance. 
     You should not be loading from the path to the plugin source code.  So 
this is incorrect.


---

Reply via email to