GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/1280
METRON-1869 Unable to Sort an Escalated Meta Alert
This fixes a bug that causes meta-alerts to not be visible in the Alerts UI
when the UI is sorted by 'alert_status' and a meta-alert has been escalated.
This is only a problem when indexing into Elasticsearch.
The root cause is that the 'alert_status' field needs to be defined as a
keyword in the metaalert index template. This field only exists in the
meta-alert index after a meta-alert has changed status, like when an alert is
escalated.
## Changes
* Fixed the Elasticsearch meta-alerts template that is deployed with the
MPack.
* Added an integration test for this bug.
## Testing
Follow the "steps to reproduce" outlined in the JIRA to ensure that the bug
has been squashed.
1. Create a meta-alert.
2. Escalate the meta-alert.
3. Submit another search that filters the results to only show meta-alerts.
4. Sort the results by âalert_statusâ field.
5. The meta-alert should still be visible.
## Pull Request Checklist
- [ ] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified
and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
- [ ] Have you written or updated unit tests and or integration tests to
verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nickwallen/metron METRON-1869
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1280.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1280
----
commit d2f56b4f41bead7b3490cb81bdce553359ce09fc
Author: Nick Allen <nick@...>
Date: 2018-11-14T13:34:17Z
Attempting to create test that highlights the problem
commit 70d1dc4bea3992f8e94eb855c36c99fde7f6cad9
Author: Nick Allen <nick@...>
Date: 2018-11-26T19:41:21Z
METRON-1869 Fix missing alert_status field in meta-alert template
commit 09558fb5fa5eb24cebfc974170fd14abf047e2e5
Author: Nick Allen <nick@...>
Date: 2018-11-26T20:51:43Z
Completed integration test that highlights the problem
commit afb87ba0b4efbc74913698e123c5661a42ac7f45
Author: Nick Allen <nick@...>
Date: 2018-11-26T20:58:47Z
Testing sorted search results under 3 scenarios
commit 60c3af90061ce82a89696c96b9f07b3e4fb35324
Author: Nick Allen <nick@...>
Date: 2018-11-26T20:59:49Z
Reset ordering
----
---
