GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/1284
METRON-1867 Remove `/api/v1/update/replace` endpoint
The `/api/v1/update/replace` endpoint is no longer used. This is dead code
and should be removed.
I have tried to isolate the changes from #1259 on to master to help
reviewers. This replaces #1259.
## Testing
1. Spin-up Full Dev.
1. Open the Alerts UI.
* View alerts.
* Escalate an alert.
* Comment on an alert.
* Create a meta-alert.
* Escalate a meta-alert.
1. Run the UI e2e tests.
## Pull Request Checklist
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nickwallen/metron METRON-1867-v2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1284.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1284
----
commit 89d1d5742005d7869728ae7a67c96acc26ce651b
Author: Nick Allen <nick@...>
Date: 2018-11-12T17:24:40Z
METRON-1867 Remove `/api/v1/update/replace` endpoint
commit 428a12f5ad883c0aa19e1c9040dee2070a97a6a4
Author: Nick Allen <nick@...>
Date: 2018-11-29T15:51:12Z
Trying to keep the changes as focused on remove the ReplaceRequest as
possible
----
---
