[ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16709144#comment-16709144 ]
ASF GitHub Bot commented on METRON-1911: ---------------------------------------- Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238796550 --- Diff: docker/in_docker_scripts/wait-for-it.sh --- @@ -0,0 +1,161 @@ +#!/usr/bin/env bash +# Use this script to test if a given TCP host/port are available + +cmdname=$(basename $0) --- End diff -- Suggest `cmdname="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null && pwd )"` as a general good practice. Probably no specific need if this works, since it's a somewhat closed environment. > [BROS]Create Docker based test environment for Bro > -------------------------------------------------- > > Key: METRON-1911 > URL: https://issues.apache.org/jira/browse/METRON-1911 > Project: Metron > Issue Type: New Feature > Reporter: Otto Fowler > Assignee: Otto Fowler > Priority: Major > > We would benefit from the ability to build and deploy bro, have it run > against standard pcaps and output to kafka, and capture the logs. > Using scripts and docker, we should be able to automate this process, as it > is often written in the prs. > These scripts could also be used in travis, with cached pcaps for regression > testing. -- This message was sent by Atlassian JIRA (v7.6.3#76005)