Github user ottobackwards commented on a diff in the pull request:

    
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238851540
  
    --- Diff: docker/example_script.sh ---
    @@ -0,0 +1,177 @@
    +#!/usr/bin/env bash
    +
    +#
    +#  Licensed to the Apache Software Foundation (ASF) under one or more
    +#  contributor license agreements.  See the NOTICE file distributed with
    +#  this work for additional information regarding copyright ownership.
    +#  The ASF licenses this file to You under the Apache License, Version 2.0
    +#  (the "License"); you may not use this file except in compliance with
    +#  the License.  You may obtain a copy of the License at
    +#
    +#      http://www.apache.org/licenses/LICENSE-2.0
    +#
    +#  Unless required by applicable law or agreed to in writing, software
    +#  distributed under the License is distributed on an "AS IS" BASIS,
    +#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +#  See the License for the specific language governing permissions and
    +#  limitations under the License.
    +#
    +
    +shopt -s nocasematch
    +
    +CREATED_NETWORK_FLAG=false
    +RAN_ZK_CONTAINER=false
    +RAN_KAFKA_CONTAINER=false
    +CREATED_BRO_CONTAINER=false
    +RAN_BRO_CONTAINER=false
    +
    +SKIP_REBUILD_BRO=false
    +LEAVE_RUNNING=false
    +
    +SCRIPT_DIR=./scripts
    +CONTAINER_DIR=./containers/bro-localbuild-container
    +CONTAINER_NAME=
    +LOG_PATH="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null && cd logs 
&& pwd )"
    +
    +function help {
    + echo " "
    + echo "usage: ${0}"
    + echo "    --skip-docker-build             Skip build of bro docker 
machine."
    + echo "    --leave-running                 Do not stop containers after 
script.  The cleanup_containers.sh script should be run when done."
    + echo "    -h/--help                       Usage information."
    + echo " "
    + echo " "
    +}
    +
    +function shutdown {
    +
    +  if [[ "$RAN_BRO_CONTAINER" = true ]]; then
    +    "${SCRIPT_DIR}"/stop_container.sh --container-name=bro
    --- End diff --
    
    the container name is not variable here, even though there is a var defined 
it isn't passed


---

Reply via email to