mmiklavc commented on a change in pull request #1389: METRON-2087: Remove Storm
dependency from metron-indexing
URL: https://github.com/apache/metron/pull/1389#discussion_r280166839
##########
File path:
metron-platform/metron-indexing/metron-indexing-storm/src/test/java/org/apache/metron/indexing/integration/HDFSIndexingIntegrationTest.java
##########
@@ -151,11 +152,11 @@ public String cleanField(String field) {
@Override
public String getTemplatePath() {
- return "../metron-indexing/src/main/config/hdfs.properties.j2";
+ return "../metron-indexing-common/src/main/config/hdfs.properties.j2";
}
@Override
public String getFluxPath() {
- return "../metron-indexing/src/main/flux/indexing/batch/remote.yaml";
+ return
"../metron-indexing-common/src/main/flux/indexing/batch/remote.yaml";
Review comment:
Should there be Storm artifacts in *-common? Probably should be
metron-indexing-storm, and will impact the metron.spec as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
