mmiklavc commented on issue #1383: METRON-1788 Batch profiler pull profile information from zookeeper URL: https://github.com/apache/metron/pull/1383#issuecomment-490532095 Looking back through the configurations utility tests, it looks like we had relied on simple config overwriting rather than explicit resetting. I think for now, what you have is fine in light of the circumstances. We've seen our build times increasing as of late and need to keep on top of it. Can you create a follow-on Jira that tracks work for zookeeper test resets? Reference the discussion from this PR in the Jira as a link, and add a link to that Jira here in the comments. Once that's set, you have my +1. Nice work @tigerquoll, thanks for the contribution! It seems that the solution would need to be a config util option to clean/delete nodes in Zookeeper. It shouldn't be too bad, considering they're all organized in directories, but it's a bit more involved than just a simple "reset." Here are a few things I'd consider looking at and providing for some added context in the new Jira ticket description I asked you to create: 1. https://github.com/apache/metron/blob/14efe83e3a8d9ba7c2bef35061fc9829ee0e61f8/metron-platform/metron-common/src/test/java/org/apache/metron/integration/components/ConfigUploadComponent.java#L138 2. https://curator.apache.org/curator-framework/index.html 3. https://github.com/apache/curator/blob/master/curator-examples/src/main/java/framework/CrudExamples.java#L119
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
