nickwallen commented on a change in pull request #1403: METRON-2109: Add option
to use Metron GUID as the id in Elasticsearch
URL: https://github.com/apache/metron/pull/1403#discussion_r282907029
##########
File path: metron-platform/metron-common/README.md
##########
@@ -87,6 +87,7 @@ but a convenient index is provided here:
| [`es.port`](../metron-elasticsearch#esport)
| Indexing | String | N/A
|
| [`es.date.format`](../metron-elasticsearch#esdateformat)
| Indexing | String |
`es_date_format` |
| [`es.client.settings`](../metron-elasticsearch#esclientsettings)
| Indexing | Object | N/A
|
+| [`indexing.writer.metronId`](../metron-indexing#elasticsearch)
| Indexing | Boolean | N/A
|
Review comment:
Maybe `indexing.writer.elasticsearch.metronId` to make is more clear that
this setting only applies to Elasticsearch, not Solr?
Or `indexing.writer.elasticsearch.setDocumentId` if you agree with my other
comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
