sardell opened a new pull request #1418: METRON-2124: [UI] Move status information and start/stop to the Aggregate level URL: https://github.com/apache/metron/pull/1418 ## Contributor Comments Link to ASF Jira ticket: https://issues.apache.org/jira/browse/METRON-2124 This PR contains work that allows us to group actions for parser groups together. When parsers are grouped, we want to be able to start/stop from the aggregate level. This means hiding individual parser controls when they are grouped, controlling multiple parsers with a single set of controls for a group, and displaying status information as a group. As stated in other PRs opened against this feature branch, this is a subset of changes that cannot be tested without other work in following PRs (will list here when they are opened). This breakdown has been done to make code reviewing easier. ## Related commits This PR contains work from other PRs that will need to first be merged into the feature branch before changes in this PR are accurately represented. PR#1 METRON-2114: [UI] Moving components to sensor parser module PR#2 METRON-2116: [UI] Removing redundant AppConfigService PR#3 METRON-2117: [UI] Aligning models to grouping feature PR#4 METRON-2115: [UI] Aligning UI to the parser aggregation AP PR#5 METRON-2122: [UI] Fixing early app config access issue ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [ ] Have you included steps or a guide to how the change may be verified and tested manually? - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - [ ] Have you written or updated unit tests and or integration tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` - [ ] Have you ensured that any documentation diagrams have been updated, along with their source files, using [draw.io](https://www.draw.io/)? See [Metron Development Guidelines](https://cwiki.apache.org/confluence/display/METRON/Development+Guidelines) for instructions. #### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
